Skip to content

update preproduction pipeline for testing avocado@0.5.0#6646

Merged
PhoenixHe-NV merged 1 commit intoAzure:masterfrom
ruowan:ruowan/dev
Jul 25, 2019
Merged

update preproduction pipeline for testing avocado@0.5.0#6646
PhoenixHe-NV merged 1 commit intoAzure:masterfrom
ruowan:ruowan/dev

Conversation

@ruowan
Copy link
Copy Markdown
Member

@ruowan ruowan commented Jul 17, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 17, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 17, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 17, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@ruowan
Copy link
Copy Markdown
Member Author

ruowan commented Jul 17, 2019 •
edited
Loading

This PR should be merged after avocado@0.5.0 released. @michaeljqzq Please take a look.

@azuresdkci azuresdkci requested a review from anuchandy July 17, 2019 03:54
@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jul 17, 2019

Can one of the admins verify this patch?

@michaeljqzq
Copy link
Copy Markdown
Contributor

michaeljqzq commented Jul 18, 2019

@ruowan Before merge, can you confirm with the CI error? It seems can't find the 0.5 version of avocado

@anuchandy
Copy link
Copy Markdown
Member

anuchandy commented Jul 18, 2019

@sergey-shandar assigning this to you as it related to CI and avocado tool.

@ruowan ruowan closed this Jul 19, 2019
@ruowan
Copy link
Copy Markdown
Member Author

ruowan commented Jul 23, 2019 •
edited
Loading

This PR isn't ready to merge until avocado@0.5.0 release. @NullMDR

@ruowan ruowan reopened this Jul 23, 2019
@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Jul 23, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 5ec6999, Iteration 7)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@ruowan ruowan changed the title update preproduction pipeline for testing avocado@0.5.0 [DONT MERGE]update preproduction pipeline for testing avocado@0.5.0 Jul 23, 2019
@ruowan ruowan changed the title [DONT MERGE]update preproduction pipeline for testing avocado@0.5.0 [DO NOT MERGE]update preproduction pipeline for testing avocado@0.5.0 Jul 23, 2019
@ruowan ruowan changed the title [DO NOT MERGE]update preproduction pipeline for testing avocado@0.5.0 update preproduction pipeline for testing avocado@0.5.0 Jul 25, 2019
@ruowan ruowan closed this Jul 25, 2019
@ruowan ruowan reopened this Jul 25, 2019
@ruowan ruowan closed this Jul 25, 2019
@ruowan ruowan reopened this Jul 25, 2019
@ruowan
Copy link
Copy Markdown
Member Author

ruowan commented Jul 25, 2019

@michaeljqzq avocado@0.5.0 has been released, so the PR is ready to merge into master.

@PhoenixHe-NV PhoenixHe-NV merged commit a871d83 into Azure:master Jul 25, 2019
@ruowan ruowan deleted the ruowan/dev branch July 25, 2019 03:28
leniatgh pushed a commit to leniatgh/azure-rest-api-specs that referenced this pull request May 13, 2022
@jchongmsft @msfcolombo
Evolved Microsoft.Pki RP, added enrollment policies API and Operation… (
ae355ce 
Azure#6646)

* Evolved Microsoft.Pki RP, added enrollment policies API and Operation Examples

Evolved Microsoft.Pki RP, added enrollment policies API.

Evolved Microsoft.Pki RP, added enrollment policies API.

Addressed ARM review feedback

Reverted migration to v3 types in order to avoid a bigger change.

Resolved all example validation failures

* PrettierCheck fixes

* Standardizing common types to V2

Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy Awaiting requested review from anuchandy

2 more reviewers

@PhoenixHe-NV PhoenixHe-NV PhoenixHe-NV approved these changes

@michaeljqzq michaeljqzq michaeljqzq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ruowan @AutorestCI @azuresdkci @michaeljqzq @anuchandy @PhoenixHe-NV @sergey-shandar